Giveth / giveth-dapps-v2

This project is the aggregation of GIVeconomy and Giveth.io DApps in a single repo
https://staging.giveth.io
GNU General Public License v3.0
64 stars 33 forks source link

when a project is vouched, allow project owner to boost their own project #4814

Open divine-comedian opened 1 month ago

divine-comedian commented 1 month ago

Currently from the project owner view, when a project is vouched and also has an incomplete GIVbacks eligiblity form they are unable to boost their project from any view on Giveth!

We should reconsider the CTA buttons we use or make the necessary design change to accomodate this scenarion

Image

Tosinolawale commented 1 month ago

Project Single - About https://www.figma.com/design/fHpNMd8Q9iBrAr6kBj9oo5/DeVouch-Giveth-Integration?node-id=8603-16467&t=ptXDi0plJ53GiteA-1 @divine-comedian @MohammadPCh @mateodaza

divine-comedian commented 1 month ago

@Tosinolawale to understand the New label shows up if the project has a incomplete form? Maybe we

Can we just make this a small notification dot instead of using the text "New"? Or could we perhaps use a warning color or notification symbol to let them know that they should check out their application is incomplete?

Tosinolawale commented 1 month ago

@Tosinolawale to understand the New label shows up if the project has a incomplete form? Maybe we

Can we just make this a small notification dot instead of using the text "New"? Or could we perhaps use a warning color or notification symbol to let them know that they should check out their application is incomplete? Project Single - About I introduced a warning/info label under the project actions https://www.figma.com/design/fHpNMd8Q9iBrAr6kBj9oo5/DeVouch-Giveth-Integration?node-id=8603-16467&t=gtqWMULOww7z7Ga2-1 @divine-comedian

divine-comedian commented 3 weeks ago

Thanks Tosin! I think we can go ahead on this. Adding the warning text when user is VOUCHED and has incomplete givbacks form

I don't think its necessary to add the notification dot when the user opens the drop down menu.

@kkatusic - Can you take this one on? Here are the requirements:

AC

When project is VOUCHED(verified=true), not givbacks eligible AND has incomplete givbacks form we should:

image

kkatusic commented 2 weeks ago

@divine-comedian we are now replacing current message: "Is your project creating or supporting public goods?"

Screenshot 2024-11-07 at 14 00 48

divine-comedian commented 2 weeks ago

@kkatusic there should be this copy we can use that replaces this copy you've shown here.

You can find the title and description from verified_owner_not_eligible label in the language json files

kkatusic commented 2 weeks ago

@divine-comedian this is what you want?

Screenshot 2024-11-08 at 11 43 15

divine-comedian commented 2 weeks ago

sort of - bear in mind this should ONLY appear when form status is incomplete AND project is vouched AND when project is NOT givbacks eligible.

I can see the project you have shown here already has givbacks status of eligible.

kkatusic commented 2 weeks ago

@divine-comedian I changed only inside administration value for eligible status for testing purpose, but form confirmation has been done for this project, that's why it is green.