search

Giveth / giveth-docs

Documentation and Guides for Giveth.io
GNU General Public License v3.0
37 stars 34 forks source link

update dapp guide #154

Closed franculio closed 1 year ago

franculio commented 1 year ago

Here's the update for:

-Replacing the image in Intro Issue#939 -Verification spelling corrections + Adding image Issue#980 -FAQ update Issue#935

@divine-comedian @danelsuga

danelsuga commented 1 year ago

Hi @franculio I still see errors in your corrections, but I don't know how I'm to proceed. For example, you've corrected "thier" to "their" but have not removed "by" in the same sentence. How do I add fixes, etc.?

Project owners can apply by directly from their project page after signing in by clicking VERIFY YOUR PROJECT.

franculio commented 1 year ago

Thank you @danelsuga! I see the "by" that you are referring to. I didn't create a google doc for this corrections since they were not so many. Next time I'll create a google doc inside the issue so we can revise things better.

danelsuga commented 1 year ago

OK, well, that's just one example. I didn't proceed at all, because I didn't know how I would be able to fix anything myself. I imagine I will find other things. Do you want me to just write them here? Seems like a clunky way to operate!

franculio commented 1 year ago

@danelsuga I'll create a google doc in the Issue#980 so you can make all the adjustments that you see necessary and then I can throw them in the update. Is that better way?

danelsuga commented 1 year ago

That would be awesome. But don't bother if it's a bunch of extra steps. I can scroll through and take notes.

franculio commented 1 year ago

No problem at all! It makes more sense as a work flow :)