search

Giveth / giveth-gatsby

Giveth 2.0 implementation in GatsbyJS
GNU General Public License v3.0
24 stars 14 forks source link

Add not found page when cant find project with slug #903

Closed mohammadranjbarz closed 3 years ago

mohammadranjbarz commented 3 years ago

Now we are showing backend error message when we can't find a project by slug, and it misleads our users, I think it's better to design a 404 page ( it has a little backend works) take a look at problems it makes now: https://github.com/Giveth/giveth-next/issues/173#issuecomment-930767491 https://github.com/Giveth/giveth-dapp/issues/2545

These are invalid links and see how we mislead users with not clear error

https://giveth.io/project/the-amanda-joyner-foundation https://next.giveth.io/project/jesus-thinks-you're-awesome

@MoeNick @mosaeedi What do you think guys?

mohammadranjbarz commented 3 years ago

It's a mistake to adding this issue here, I close this and you can check https://github.com/Giveth/giveth-next/issues/274