Giveth / giveth-next

Giveth 2.0 implementation in NextJS
https://next.giveth.io
GNU General Public License v3.0
20 stars 13 forks source link

Allow Giveth Projects to Accept Any Token #448

Open GriffGreen opened 2 years ago

GriffGreen commented 2 years ago

📋 Anything to add?

Losing the QR code has an impact :-/ We need to allow people to donate Any Token... even if it's not going to get GIVbacks or going to have a price for the donation page... people should be able to donate their airdrops

Basically people should be able to paste in a Token Address Into the donation field: Screen Shot 2021-12-05 at 11 43 20 AM

⏰ Urgency/Deadline/Blockers?

Depends on scope... if we scope it narrowly its easy-ish... lets get it in before launch

❓ Why is it important?

So many people have their own favorite token... and token abundance... they want to share... Think Founders of a shit coin. Their Token might not get GIVbacks... but they should be able to donate it

🎉 Subtasks

🤼‍ Reviewer

@MoeNick

🔗 Work doc - inspirational links

MoeNick commented 2 years ago

@aminlatifi do we have a web service to fetch new token name and logo based on the address?

MoeNick commented 2 years ago

@markoprljic @mosaeedi I think we can add an option that user select a radio button: "Select from currant token" OR "I have token Address" . we need to review the UX and design the UI for it.

markoprljic commented 2 years ago

It's just a matter of pasting a token address in the dropdown menu search and it shows the token (if found) with link below "Import". Similar how you do on any DEX. No need for radio button.

On Mon, Dec 6, 2021 at 3:45 PM Moe Nick @.***> wrote:

@markoprljic https://github.com/markoprljic @mosaeedi https://github.com/mosaeedi I think we can add an option that user select a radio button: "Select from currant token" OR "I have token Address" . we need to review the UX and design the UI for it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Giveth/giveth-next/issues/448#issuecomment-986842357, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLQUXMCEIF6LHSRWBW4VBDUPTEBXANCNFSM5JNBAGLQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Marko Prljić Design Scientist

aminlatifi commented 2 years ago

on

No!

MoeNick commented 2 years ago

Please update us here if you have any pr for this. @mateodaza

divine-comedian commented 2 years ago

testing on next.giveth.io on both MAINNET and XDAI

on the donate page I can successfully paste in any token address and it will load the token ticker (TDAI, xSDT or whatever) and it will allow me to put in an amount and generate the metamask transaction. image image

looks to be working fine for regular giveth projects