Giveth / giveth-next

Giveth 2.0 implementation in NextJS
https://next.giveth.io
GNU General Public License v3.0
20 stars 13 forks source link

If a user is trying to donate to a verified project with a not-whitelisted GIVbacks token, they get a popup explaining that they might not get GIVbacks #606

Open laurenluz opened 2 years ago

laurenluz commented 2 years ago

The user selects the (non-whitelisted) to token and clicks "donate". They get a popup that says:

"The token you have selected to donate is not eligible for GIVbacks. To see the full list of eligible tokens, please refer to our GIVbacks Token List forum post."

Where "GIVbacks Token list forum post" is a link to https://forum.giveth.io/t/givbacks-token-list/253

And there is a button that says "DONATE ANYWAY" that prompts the tx And smaller text under that says "CANCEL" that closes the modal and lets the user pick another token.

MoeNick commented 2 years ago

Is that decision was already made from the forum post?

@divine-comedian @mohammadranjbarz you may make it more clear

mohammadranjbarz commented 2 years ago

Is that decision was already made from the forum post?

  • Do we have to have a token white list in the backend?
  • Should we only have one white list fir every project? Or it should be change for the type of project ?
  • How are we going to update the white list? Once a day? From which source?

@divine-comedian @mohammadranjbarz you may make it more clear

  1. Not as you think, we should make it and implement a query to frontend use it
  2. I think we should have one whitelist for verified tokens and it's not related to projects, whitelist for every project just makes complexity, and with the things that talked in forum post, I can,t find any reason for that
  3. @laurenluz or @divine-comedian Can answer that
laurenluz commented 2 years ago

The details of the whitelist haven't been confirmed yet on the forum, but we will have them for sure!!

This issue is blocked by completion of the GIVbacks token whitelist

laurenluz commented 2 years ago

ok! @MoeNick, as per my proposal in the forum: https://forum.giveth.io/t/which-tokens-donated-are-eligible-for-givbacks/231/9 (which seems very likely to pass)

We're calling it the "GIVbacks Token List" and it will be same for every verified project. The list will include the tokens we have already added to the DApp (in the donation drop down menu) and will list them in a post on the forum (I will create it). When people want to add new tokens, they can comment in the forum and we will vote to determine if it should be added.

We can make a the frequency by which we update the list based on how frequently we get requests to add new tokens in the forum.

mateodaza commented 2 years ago

I'm trying to come up with a great UX for this but struggling to make it the less annoying as possible, do you have any suggestion? @laurenluz

I was thinking instead of a popup, it's just a clearer message near the button

laurenluz commented 2 years ago

What if we made it a little red text alert thing under here that says "This Token is not eligible for GIVbacks. Learn More." And "Learn More" is clickable and it opens the popup I described in my first issue.

image

laurenluz commented 2 years ago

FYI - the token list is up in the forum! https://forum.giveth.io/t/givbacks-token-list/253

I edited the suggestion in the issue so that the list is here, rather than in the documention.

laurenluz commented 2 years ago

@markoprljic FYI

markoprljic commented 2 years ago

Changes made to accommodate the scenario of donating with GIVbacks eligible and not eligible tokens.

  1. User should be able to see this in the token list dropdown Image 2022-01-12 at 2 03 16 pm

  2. When not eligible token selected Image 2022-01-12 at 2 04 07 pm

  3. When eligible token selected Image 2022-01-12 at 2 04 15 pm

Learn more opens a modal with more info. Please use standard modal component and add copy about What are GIVbacks to inform user about it, just briefly. DO NOT include any other links that will lead away from the donation process user is currently in.

@laurenluz @MoeNick

P.S. I just realised this issue is for old dapp :/ Nevermind, it applies to new version as well :)

MoeNick commented 2 years ago

Oh Great

laurenluz commented 2 years ago

@markoprljic the GIVbacks token list is the same as our drop-down list of tokens (right? @mateodaza @mohammadranjbarz) so the tokens that won't be eligible are ones that user copy/pastes in the address for. I don't think we need to have the "all" and "GIVbacks eligible" selectors.

I do think we should keep the message "This Token is/is not eligible for GIVbacks Learn more"

I also totally understand that we don't want to send the user away from the donation page... but we should someone make it easy/possible for the to navigate from a page referring to the token list... to the token list itself... then if they want to request a token to be added to the list, they can do so.

I can write copy for the modal, but waiting on your feedback.

MoeNick commented 2 years ago

We'd better continue it on TP version, so I move the @laurenluz comment to a new issue and transfer it there, it's in our current sprint.