Giveth / impact-graph

MIT License
49 stars 18 forks source link

Replace ortto External Embedded Webform for Onboarding guide #1548

Closed divine-comedian closed 2 weeks ago

divine-comedian commented 4 months ago

Currently we have an Onboarding guide listed on https://giveth.io/onboarding that includes a form for users to input their email to receive onboarding guide series of emails.

image

This webform is using an embedded external script, built by Ortto and uses it's own API key to make updates to our CRM and send emails out. Currently it is causing unpredictable behaviour in our CRM, such as changing the userId of customers in our CRM.

We should not use an external script an instead create the form directly into our website and call our API with explicitly the data and behaviour we want to update our CRM.

We also need to edit the journey that is sending this onboarding guide to look for the new activity that will trigger it.

image

Originally posted by @divine-comedian in https://github.com/Giveth/impact-graph/issues/1494#issuecomment-2096804849

RamRamez commented 4 months ago

Thanks @divine-comedian do we have and Ortto activity for that? because I can't find it in activities list

divine-comedian commented 4 months ago

Thanks @divine-comedian do we have and Ortto activity for that? because I can't find it in activities list

Just made it - image

endpoint

https://api-us.ortto.app/v1/activities/create

body attributes

    "activities": [
        {
            "activity_id": "act:cm:onboarding-form",
            "attributes": {
                "str:cm:email": "example string value",
            },
            "fields": {
                "str::email": "contact@email.com"
            },
RamRamez commented 2 months ago

@divine-comedian activity is triggered but I didn't receive any email. Could you check please?

image
divine-comedian commented 2 months ago

Sorry about that @RamRamez - there was no journey connected to the activity - it should work now

image

RamRamez commented 2 months ago

@divine-comedian I tested with three different email addresses but didn't get any email.

divine-comedian commented 2 months ago

@divine-comedian I tested with three different email addresses but didn't get any email.

OMG then I have to turn on each individual email - WHO DESIGNED THIS!!!

It should work now @RamRamez :sweat_smile:

RamRamez commented 2 months ago

I received email for my gmail but didn't receive any email for my outlook account although Ortto activity has been triggered

image
RamRamez commented 2 months ago

@divine-comedian Journey is not triggered for ramin first

image
divine-comedian commented 2 months ago

@RamRamez - I can see it here in the activity panel, maybe it was a bit slow image

FYI you can only receive each email ONCE per email address

RamRamez commented 2 months ago

@maryjaf @LatifatAbdullahi Please test and verify

https://staging.giveth.io/onboarding

maryjaf commented 2 months ago

There is no problem in sending emails. but it would be good a message is shown when user set an invalid email address

RamRamez commented 2 months ago

@maryjaf We have this error for invalid address

image
divine-comedian commented 2 months ago

There is no problem in sending emails. but it would be good a message is shown when user set an invalid email address

There is only the warning we give when user enters the text in an invalid email format. If I understood you correctly I would consider it out of scope to check if the user entered a real email address into the input box.

divine-comedian commented 2 months ago

@RamRamez - LMK when this passes QA and hits production so I can delete the other source API that's being used on the current production webform