Closed mohammadranjbarz closed 4 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The updates encompass modifications to TypeORM migration scripts, entity classes, and various test files. Key changes include the addition and removal of columns in the qf_round
table, the replacement of the admin
field with adminUserId
, and the introduction of caching mechanisms. New methods and classes were added for enhanced functionality, and test cases were updated to reflect these changes.
File(s) | Change Summary |
---|---|
migration-old-backup/1714018700116-add_archived_QFRound_fields.ts |
Added and removed bannerBgImage and sponsorsImgs columns in qf_round table. |
migration/1654415838996-fillRelatedAddressesFromProjectsTable.ts |
Replaced project.admin with project.adminUserId in insertRelatedAddress function. |
migration/1712853017092-UserNewRoleQfManager.ts |
Conditional block for adding enum value in up method; simplified down method. |
migration/1715521134568-relate_current_mini_stream_donations_to_qf_Rounds.ts |
Added migration to relate mini stream donations to QF rounds. |
migration/1715556030126-dropAdminColumn.ts |
Dropped admin column from project table. |
migration/1716549958362-add_donations_mannually_to_db.ts |
Added script to manually populate donations data. |
package.json |
Added dependencies and scripts for testing. |
src/adapters/notifications/NotificationCenterAdapter.ts |
Removed projectOwnerId from getEmailDataDonationAttributes function. |
src/entities/project.ts |
Removed admin , users , and owner method; added adminUserId property. |
src/entities/projectDonationSummaryView.ts |
Introduced ProjectDonationSummaryView class for project donation summary. |
src/entities/user.ts |
Removed projects property; adjusted cache settings and imports. |
src/repositories/powerBoostingRepository.ts |
Added caching to findPowerBoostingsCountByUserId function. |
src/repositories/previousRoundRankRepository.test.ts |
Modified beforeEach hook to skip tests based on dbIndependentTests . |
src/repositories/projectAddressRepository.test.ts |
Replaced admin with adminUserId in test cases. |
src/repositories/projectRepository.test.ts |
Renamed admin to adminUserId in project verification tests. |
src/repositories/projectRepository.ts |
Removed left join with project.users ; added findProjectIdBySlug function. |
src/repositories/projectVerificationRepository.test.ts |
Updated admin to adminUserId in multiple test functions. |
src/repositories/projectVerificationRepository.ts |
Added error handling and logging; new function getVerificationFormStatusByProjectId . |
src/repositories/qfRoundRepository.ts |
Added fields to QFArchivedRounds ; updated findArchivedQfRounds function. |
src/repositories/socialProfileRepository.test.ts |
Updated admin to adminUserId in social profile tests. |
src/repositories/userRepository.test.ts |
Updated admin to adminUserId in findUsersWhoSupportProjectTestCases . |
src/resolvers/donationResolver.test.ts |
Added test case for recurring donations in mini donations; updated assertions. |
src/resolvers/donationResolver.ts |
Added left join and select for donation.recurringDonation . |
src/resolvers/draftDonationResolver.ts |
Added comment suggesting bigInt for createDraftDonation method's amount parameter. |
src/resolvers/projectResolver.allProject.test.ts |
Updated admin to adminUserId in allProjectsTestCases . |
src/resolvers/projectResolver.test.ts |
Consistently renamed admin to adminUserId across test cases. |
In the land of code, where changes flow, Columns come and columns go. Admins now with IDs stand, Projects flourish, sleek and grand. Tests refined, and caches set, A smoother path for all is met. 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
How can I test this ? @mohammadranjbarz
How can I test this ? @mohammadranjbarz
It's not merged yet, but after emerging this you should see the donations in the matching-pool project page
Related to https://github.com/Giveth/giveth-dapps-v2/issues/4201
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
admin
field withadminUserId
for clarity and consistency.Chores
package.json
.