search

Giveth / impact-graph

MIT License
47 stars 16 forks source link

fix: filter unique donors based on passport score and knownAsSybilAdd… #1613

Closed Meriem-BM closed 3 weeks ago

Meriem-BM commented 4 weeks ago

Related to https://github.com/Giveth/giveth-dapps-v2/issues/4245

Added a condition to count only the unique donors that has

cc: @CarlosQ96

Summary by CodeRabbit

coderabbitai[bot] commented 4 weeks ago

Walkthrough

The updates introduce a new field isDataAnalysisDone to the QfRound entity, impacting various parts of the application including database schema, repository logic, and admin interface. Additionally, the calculation for uniqueDonors in findArchivedQfRounds was enhanced to consider user attributes. Minor styling adjustments were made in the QFRoundSponsorsImgs.tsx component.

Changes

Files Change Summary
src/repositories/qfRoundRepository.ts Modified findArchivedQfRounds to include isDataAnalysisDone and updated uniqueDonors calculation.
migration/1717930067669-AddIsDataAnalysisDoneToQFRound.ts Added migration script to introduce isDataAnalysisDone column to qf_round table.
src/entities/qfRound.ts Added isDataAnalysisDone field to QfRound class.
src/server/adminJs/tabs/qfRoundTab.ts Updated validateQfRound function and visibility settings for isDataAnalysisDone.
src/server/adminJs/tabs/components/QFRoundSponsorsImgs.tsx Adjusted styling properties for Container, FileContainer, and DropZone components.

Sequence Diagram(s)

sequenceDiagram
    participant Admin as Admin Interface
    participant Repo as QfRound Repository
    participant DB as Database

    Admin->>Repo: Call findArchivedQfRounds()
    Repo->>DB: Query with left join on donation.user
    DB-->>Repo: Return QfRound data with uniqueDonors and isDataAnalysisDone
    Repo-->>Admin: Return processed QfRound data

    Admin->>DB: Add isDataAnalysisDone column via migration
    DB-->>Admin: Column added successfully

Poem

In fields of code where data flows,
A new flag in the round now shows.
Analysis done, we mark with pride,
Unique donors, we now decide.
With styling tweaks and joins anew,
Our system grows, for me and you. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.