Closed ae2079 closed 3 months ago
Recent changes focus on enhancing error logging across various server functions and services, adjusting the logging level from error
to fatal
to improve visibility for critical failures. Additionally, a new constant FAILED_VERIFICTION_ALERT_THRESHOLD
is introduced in the donation service to monitor and log prolonged verification failures.
File Path | Change Summary |
---|---|
src/server/bootstrap.ts |
Changed logging level from error to fatal in bootstrap() and continueDbSetup() . |
src/services/chains/evm/draftDonationService.ts |
Changed logging level from error to fatal in submitMatchedDraftDonation . |
src/services/chains/evm/draftRecurringDonationService.ts |
Changed logging level from error to fatal in submitMatchedDraftRecurringDonation . |
src/services/donationService.ts |
Introduced FAILED_VERIFICTION_ALERT_THRESHOLD to log donation age if verification exceeds threshold. |
No relevant diagrams needed for these changes as they primarily involve logging levels and constants.
In code's vast sea, errors now stand tall,
Fromerror
tofatal
, we heed every call.
Donations monitored with vigilant grace,
Logging their journey in time's embrace.
🎩🐇 In Rabbit’s code, precision rules all.
src/server/bootstrap.ts
[error] 152-159: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse) Unsafe fix: Omit the else clause.
src/services/chains/evm/draftRecurringDonationService.ts (1)
`167-167`: Change from `error` to `fatal` logging level is appropriate if the error is critical and affects the system's stability or data integrity.src/services/chains/evm/draftDonationService.ts (1)
`294-294`: Change from `error` to `fatal` logging level is appropriate if the error is critical and affects the system's stability or data integrity.src/server/bootstrap.ts (2)
`304-304`: Change from `error` to `fatal` logging level is appropriate given the critical nature of the `bootstrap` function. --- `432-432`: Change from `error` to `fatal` logging level is appropriate given the critical nature of the database setup in the `continueDbSetup` function.src/services/donationService.ts (1)
`266-266`: Introduction of `FAILED_VERIFICTION_ALERT_THRESHOLD` constant is appropriate for managing failed donation verification scenarios.
Summary by CodeRabbit
Bug Fixes
fatal
level for better diagnostics in various donation services.New Features