Closed RamRamez closed 2 days ago
[!WARNING]
Review failed
The pull request is closed.
The changes introduce a new method subscribeOnboarding
within several files to handle the onboarding notification process. These modifications include: integrating this method into the MockNotificationAdapter
, updating the NotificationAdapterInterface
, modifying the NotificationCenterAdapter
, adding a corresponding event name in the analytics.ts
, and creating a new OnboardingFormResolver
class to manage onboarding subscriptions using email addresses.
File | Change Summary |
---|---|
src/adapters/notifications/MockNotificationAdapter.ts |
Added subscribeOnboarding method that logs a debug message before resolving a promise. |
src/adapters/notifications/NotificationAdapterInterface.ts |
Integrated subscribeOnboarding method into the interface. |
src/adapters/notifications/NotificationCenterAdapter.ts |
Added subscribeOnboarding method to handle subscription notifications and made userWalletAddress optional in SendNotificationBody . |
src/analytics/analytics.ts |
Updated NOTIFICATIONS_EVENT_NAMES enum to include SUBSCRIBE_ONBOARDING . |
src/resolvers/onboardingFormResolver.ts |
Introduced OnboardingFormResolver class with a subscribeOnboarding method. |
sequenceDiagram
participant Client as Client
participant Resolver as OnboardingFormResolver
participant NotificationCenter as NotificationCenterAdapter
participant MockNotification as MockNotificationAdapter
Client->>Resolver: subscribeOnboarding({ email })
Resolver->>NotificationCenter: subscribeOnboarding({ email })
NotificationCenter->>MockNotification: subscribeOnboarding({ email })
MockNotification-->>NotificationCenter: Promise<void>
NotificationCenter-->>Resolver: Promise<void>
Resolver-->>Client: Subscription confirmed
Amidst the code where logics blend, A new method we append, Subscribing to onboarding's might, With emails sent, the future's bright. Notifications rise and flow, In lines of code, success will glow. 🌟
[!TIP]
Early access features: enabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
https://github.com/Giveth/impact-graph/issues/1548
Summary by CodeRabbit
New Features
Enhancements