search

Giveth / impact-graph

MIT License
47 stars 16 forks source link

Added on final step for verification project data #1658

Open kkatusic opened 1 week ago

kkatusic commented 1 week ago

@RamRamez I added additional step for submiting verifiacation. Didn't find any test related to this part of code, correct me if I'm wrong.

Please can you check code and let me know, thx ;)

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

The primary changes involve updating the handling of the PROJECT_VERIFICATION_STEPS.SUBMIT step in the updateProjectVerificationFormByUser function within the projectVerificationFormService.ts file. Specifically, it adds calls to updateManagingFundsOfProjectVerification with data from findProjectVerificationFormById, thereby enhancing the data processing before submission.

Changes

Files Summary
src/.../projectVerificationFormService.ts Enhanced updateProjectVerificationFormByUser to call findProjectVerificationFormById and process data before invoking updateManagingFundsOfProjectVerification for PROJECT_VERIFICATION_STEPS.SUBMIT.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ProjectVerificationFormService
    participant Database

    User->>ProjectVerificationFormService: updateProjectVerificationFormByUser(step)
    alt step is SUBMIT
        ProjectVerificationFormService->>Database: findProjectVerificationFormById
        Database-->>ProjectVerificationFormService: return form data
        ProjectVerificationFormService->>ProjectVerificationFormService: process data
        ProjectVerificationFormService->>ProjectVerificationFormService: updateManagingFundsOfProjectVerification(form)
        ProjectVerificationFormService->>ProjectVerificationFormService: submitProjectVerificationForm(form)
    end
    ProjectVerificationFormService-->>User: verification form submitted successfully

Poem

In code we trust, we do commit, With forms to verify and submit. Data fetched, processed, and aligned, 🐇 CodeRabbit sings, enhancements combined! Now projects flow, smooth and bright, Happy devs coding through the night. 🌙

[!TIP]

AI model upgrade ## `gpt-4o` model for reviews and chat is now live OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide any feedback or to report any issues.
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 80bf7f12779fc9a9fb1ca01a288cd8e66b1f6bc8 and e3d7294c6dc6e6fd1338f40537e6b679022ec18f.
Files selected for processing (1) * src/services/projectVerificationFormService.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1) * src/services/projectVerificationFormService.ts
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
kkatusic commented 2 days ago

Thanks @kkatusic. Approved!

I think there's a typo in getdProjectVerificationData

@RamRamez you are right, fixed, thx you for all help

kkatusic commented 6 hours ago

Thanks @kkatusic

@RamRamez it's not passing test, can you see error?

RamRamez commented 5 hours ago

@kkatusic lots of tests are failing, I think it's not related to your PR because staging is also failing. @mohammadranjbarz do you know what's the problem?