search

Giveth / impact-graph

MIT License
49 stars 18 forks source link

get donation to giveth with donation box analytics #1661

Closed ae2079 closed 2 months ago

ae2079 commented 3 months ago

related to: https://github.com/Giveth/analytics-dashboard/issues/15

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

Recent updates include the introduction of new test cases for donation metrics and relevant donations, along with additional properties for donation data interfaces. Furthermore, modifications have been made to existing test cases in the project resolver tests, specifically adjusting the updateId values. These changes enhance testing coverage and accuracy for donation and project functionalities.

Changes

Files Change Summaries
src/…/donationRepository.test.ts Added findRelevantDonations function with associated test cases and introduced assertThrowsAsync.
src/…/donationResolver.test.ts Added donationMetrics test suite with new cases, along with supporting entities and utilities for testing donation metrics.
test/testUtils.ts Added useDonationBox and relevantDonationTxHash properties to CreateDonationData interface.
src/…/projectResolver.test.ts Changed updateId values from projectUpdateCount + 1/2 to projectUpdateCount + 10 in editProjectUpdateTestCases and deleteProjectUpdateTestCases.

Poem

Amid the code tall, New tests rise and metrics call. Donations find their place, Projects keep a steady pace. With IDs shuffled, updates blend, Our code's story finds no end. 🐇💻✨

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between ef78ded19b4a7c8e1fb75b8f68b05438af67a5a1 and 493bd2d31d7779655cbfee2194b1d1265dcb4cbe.
Files selected for processing (1) * src/resolvers/projectResolver.test.ts (2 hunks)
Additional comments not posted (1)
src/resolvers/projectResolver.test.ts (1)
`5495-5495`: **Ensure proper error handling.** The error message 'Project update not found.' should be consistent with other error messages, potentially using a centralized error message constant. ```diff - assert.equal(result.data.errors[0].message, 'Project update not found.'); + assert.equal(result.data.errors[0].message, errorMessages.PROJECT_UPDATE_NOT_FOUND); ``` > Likely invalid or redundant comment.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
ae2079 commented 2 months ago

Thanks @ae2079 LGTM Do these things

* Merge staging to your branch and resolve conflict

* Make sure all test cases pass

* [Optional] If it's not too hard for you you can run these migrations on your local system (with dump of staging DB that I can send a dump to you if you want to) and see if the migration of filling existing donations works properly or not

I already tested migrations locally and will do two other points you mentioned. thanks @mohammadranjbarz