Giveth / impact-graph

MIT License
49 stars 18 forks source link

remove GIVpower sort from project search results #1811

Closed divine-comedian closed 1 month ago

divine-comedian commented 2 months ago

Based on feedback from users and stakeholders we should further improve how we handle our search results returned on the app.

When a user currently searches for a project on Giveth we take the keywords and look for the closest match. We then sort those results based on the GIVpower of the projects returned. This means the project that might have matched closest to the search query is not returned at the top, and in some cases it is found several pages down, leading users to think the search is broken!

When a user is searching for a project by default we should not apply any sorting to the results, if the user wishes they can apply a sort to it after the initial results have been returned.

Image

@aminlatifi tagging you on this since you have the latest experience in tuning our search queries. Let me know when you can pick this up after your immediate priorities on QACC have settled.

AC

MohammadPCh commented 1 month ago

Hmm, I believe we need to update the UI/UX for this. In the current user flow, the "Sort by" option is visible and already has a value, which could be causing some confusion.

One option could be to skip the sorting when a search term is entered, or we could add something like a "No order" option in the sort menu.

What do you think, @divine_comedian?

divine-comedian commented 1 month ago

Hmm, I believe we need to update the UI/UX for this. In the current user flow, the "Sort by" option is visible and already has a value, which could be causing some confusion.

One option could be to skip the sorting when a search term is entered, or we could add something like a "No order" option in the sort menu.

What do you think, @divine_comedian?

I would recommend we could show an option in the sort drop down that says "Best Match" which refers to closest match to the keyword entered

let's use this icon from the DS to be shown along with this option image https://www.figma.com/design/d3ciTS36toS9mra0RAPMe2/Giveth-Design-System-v0.1?node-id=5121-4309&t=vkrYF2vXuyvXp5QF-4

when user is not using search feature we should not show this option.

MohammadPCh commented 1 month ago

OK, I think the best way for us is to use elastic search in the future, but for now, I'll leave a PR for it.

aminlatifi commented 1 month ago

Hmm, I believe we need to update the UI/UX for this. In the current user flow, the "Sort by" option is visible and already has a value, which could be causing some confusion. One option could be to skip the sorting when a search term is entered, or we could add something like a "No order" option in the sort menu. What do you think, @divine_comedian?

I would recommend we could show an option in the sort drop down that says "Best Match" which refers to closest match to the keyword entered

let's use this icon from the DS to be shown along with this option image https://www.figma.com/design/d3ciTS36toS9mra0RAPMe2/Giveth-Design-System-v0.1?node-id=5121-4309&t=vkrYF2vXuyvXp5QF-4

when user is not using search feature we should not show this option.

"Most Relevant" is also can be a good fit :)

MohammadPCh commented 1 month ago

@divine-comedian Should we adjust the sort to 'best match' when a user performs a search? For example, if a user has sorted by 'newest' but enters a new search term, should we automatically switch the sort to 'best match' or keep it as is?

divine-comedian commented 1 month ago

yes

maryjaf commented 1 month ago

https://staging.giveth.io/projects/all?searchTerm=how&sort=BestMatch

  • user searches should apply the closest match to the project title and/or description and show up as the highest results
  • on sorting menu user should see Best Match selected when they have made a search query along with the above mentioned icon
  • Best Match sorting option does not show up as an option if user has not made a search query
  • user can select from sorting menu other sorting options for search query such as "newest", "givpower", "GIVbacks %"

All Acs have been passed

divine-comedian commented 1 month ago

@MohammadPCh we'll need to handle this same scenarios above when a search is made from the navbar and apply it as a hotfix

image