Giveth / liquidity-mining-dapp

liquidity-mining-dapp.vercel.app
GNU General Public License v3.0
9 stars 2 forks source link

Add RegenStreams section to https://giv.giveth.io/givstream #176

Closed willyogo closed 2 years ago

willyogo commented 2 years ago
  1. A new section is added to the GIVstream titled RegenStreams, and the sections of the Streams page are rearranged according to the mockup
  2. Subtitle: When you harvest farming rewards from the RegenFarms, a portion of the rewards is added to a RegenStream. Each stream flows continuously until its respective end date. [Learn more.](https://giveth.io/placeholder-for-a-link-to-a-blog-post)

Mockup

aminlatifi commented 2 years ago

It's almost done in #183, just styling doesn't match with mock.

laurenluz commented 2 years ago

@MohammadPCh Can you help with this one?

MohammadPCh commented 2 years ago

@MohammadPCh Can you help with this one?

@laurenluz I Implemented it in this pr :

aminlatifi commented 2 years ago

To test use preview link available in https://github.com/Giveth/liquidity-mining-dapp/pull/183

divine-comedian commented 2 years ago

title and subtitle has been updated https://github.com/Giveth/liquidity-mining-dapp/pull/183/commits/ab570f253c7618e51227ebc1437717a0915a619c

laurenluz commented 2 years ago

It is showing up, but... is there a reason the Fox stream is duplicated? I think this is a bug... I'm testing on PR #183

@MohammadPCh @aminlatifi

image

aminlatifi commented 2 years ago

@laurenluz it,s based on design

laurenluz commented 2 years ago

@aminlatifi @MohammadPCh please remove the top redundant section as per our GIVeconomy call

so it shoudl just have this one: image

divine-comedian commented 2 years ago

testing on https://giveth-dapps-v2.vercel.app/givstream

image

appears to be only one FOXstream now ..

A related question though - similar to the issue of showing the farming card when on a different network - currently the stream is completely hidden when we are not on Gnosis Chain - should we show the stream regardless of the network and on the harvest card prompt the user to switch to {eligible network}?

laurenluz commented 2 years ago

@markoprljic would love your opinion here on mitch's question

markoprljic commented 2 years ago

Similar answer to mention issue. Cc @mosaeedi