Giveth / liquidpledging

Liquid Pledging
GNU General Public License v3.0
66 stars 39 forks source link

remove useless methods #36

Closed ewingrj closed 5 years ago

ewingrj commented 7 years ago

mConfirmPayment and mCancelPayment are only callable by the vault. However, the vault never calls them and has a much simpler way to deal with confirming and canceling multiple payments using only the paymentId, which doesn't require encoding the pledge id & amount into a single value for each pledge.

thus mConfirmPayment and mCancelPayment can never be called.

jbaylina commented 7 years ago

They are not useless.