search

Giveth / liquidpledging

Liquid Pledging
GNU General Public License v3.0
66 stars 39 forks source link

Redundant getter in LiquidPledgingMock #41

Closed Quazia closed 7 years ago

Quazia commented 7 years ago

There's a getter in LiquidPledgingMock.sol for mock_time. It seems like this is redundant since it's already public access. This and I would switch mock_time to mixed case. I also think it might make sense to be able to set the block time for the mock in the constructor.

ewingrj commented 7 years ago

the getTime function overrides LiquidPledging.sol getTime and is used in testing to "advance" the current time.

What do you mean set the blocktime? are you talking about mock_time? What would be the use?

Quazia commented 7 years ago

Oh, that makes sense. Yeah, I didn't realize it was overriding. I'm closing this issue but I still think that mock_time should follow mixedcase.