Reward DAO Campaign not adding the authorized payments to the vault?

[GriffGreen]

Ok I went around for a while on this... please skip to the bottom if you want to get to the meat!

As my investigation progressed i thought the core problem was that the campaign deployer needs to add the step of approving the milestone tracker as an approvedSpender, but was wrong... so now i'm really confused

Here is my rambling to figure this out:

according to the UI there should be 2 payments ready for the RewardDAO vault, but i dont see them on etherscan:

https://etherscan.io/address/0xb826c5bfea40eb88ec540abc534ad66bb5d58315#readContract

Once they get on the vault, then i can make a new one for this last week, without deleting these 2

I am not suprised that there is an issue here because the reviewer of these milestones did not manually approve these... instead they made it passed the review time... this was an issue in the old dapp where the old ui didnt have a function to call to requestMilestonePayment or whatever the function in the milestone tracker is that lets this happen. so the magic that happens in this scenario is very untested.

The new dapp has that function tho, and i called it days ago: https://etherscan.io/tx/0x52bac42560c03b315980bd9801ca48c7d60926fad311147b72efe83facc87ee6

Since it did not throw, that means that this was executed:

if (!milestone.paymentSource.call.value(0)(milestone.payData)) throw;

0xb826c5bFea40eB88EC540abc534Ad66bb5d58315 <---- the vault I would expect is listed as a payment source was called according to this:

https://etherscan.io/vmtrace?txhash=0x52bac42560c03b315980bd9801ca48c7d60926fad311147b72efe83facc87ee6&type=parity

So wtf? Why are these not listed as authorized payments on the vault?

[GriffGreen]

I tried to submit milestones tonight again tonight... as usual, i couldnt help myself but make 5 issues about the dapp while doing it... which makse it take forever :-P

but it still didnt go to the vault

https://etherscan.io/tx/0x23067ae07aa1a4d294e61b91a33d4bf2f273c4c33a8ee1b5dbb83d4e59f9de9d

looks like it has the same broken paydata (Missing the reference parameter)

https://etherscan.io/vmtrace?txhash=0x23067ae07aa1a4d294e61b91a33d4bf2f273c4c33a8ee1b5dbb83d4e59f9de9d&type=parity

so what i'm guessing is that Jordi fixed the old dapp... but not the new dapp on the develop branch?

[vojtechsimetka]

No I believe he jusg made changes to the givethdirectory and milestone tracker but we are still using old version of these dependencies?

[rodney757]

I can't upgrade the dependencies here b/c the givethcampaign abi is missing in the latest changes

On Tue, Aug 1, 2017 at 10:54 PM, vsimetka notifications@github.com wrote:

No I believe he jusg made changes to the givethdirectory and milestone tracker but we are still using old version of these dependencies?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Giveth/milestonetracker-ui/issues/69#issuecomment-319574998, or mute the thread https://github.com/notifications/unsubscribe-auth/ADwox5Px7RZtut2DfRK8PWu2sDJaMzemks5sUA8NgaJpZM4OnRIr .

[jbaylina]

Fixed in givethdirectory@0.2.3