search

Giveth / milestonetracker-ui

User Interface for the Milestone Tracker
GNU General Public License v3.0
8 stars 11 forks source link

Tx is declared to have been mined, when it hasnt been! #73

Open GriffGreen opened 7 years ago

GriffGreen commented 7 years ago

LIARS! All of you! I thought the blockchain was playing favorites when my 2 gwei gas price was mined instantly.. but then i find out... NO! ITS ALL A LIE!

dapp/js/containers/NotificationListContainer.jsx

That notification in line 44 was triggered.. but it should have been the awesome one below, that says its in process :-D

Dude guys, the dapp has gaind some major swagger in the last couple of weeks. Thanks!

GriffGreen commented 7 years ago
screen shot 2017-08-02 at 1 12 10 am

(smh) such a lie

rodney757 commented 7 years ago

what action is this happening for? all of them or only a specific one/few?

On Tue, Aug 1, 2017 at 4:12 PM, Griff Green notifications@github.com wrote:

[image: screen shot 2017-08-02 at 1 12 10 am] https://user-images.githubusercontent.com/14945613/28850933-aa16e3b8-771f-11e7-9e05-df4d5a0455f5.png (smh) such a lie

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Giveth/milestonetracker-ui/issues/73#issuecomment-319522654, or mute the thread https://github.com/notifications/unsubscribe-auth/ADwoxwQ-zvzLLeEHKnE2FaQsJPSpzYhWks5sT7DrgaJpZM4OqZlK .

rodney757 commented 7 years ago

so it looks like the tx in the pic was for markMilestoneComplete action.

While I didn't explicitly test that action due to issues with addresses, I did test this using the propose action (which uses the same functions/behavior to send the tx, so theoretically should produce identical behavior). With testrpc set to use 30s block times, everything was behaving as expected. The blue pending notification was display first followed by the green mined after it was successfully mined.

A thing to note is if the tx throws, we will display the mined notification as there isn't a good way to detect tx errors in web3.

@GriffGreen Still curious if this happens during all actions you've tried or just a specific 1 or 2?

GriffGreen commented 7 years ago

I have never seen the blue box, only the green box... I will try agin now.