Prevent project received emails going out for endaoment projects to project owner

Giveth / notification-center

It's a microservice that would handle all notification of giveth.io and trace.giveth.io

GNU General Public License v3.0

24 stars 2 forks source link

Prevent project received emails going out for endaoment projects to project owner #100

Closed divine-comedian closed 2 months ago

divine-comedian commented 4 months ago

Since Endaoment projects will be owned by one profile, it does not make sense for donations received to trigger an email sent to the project owner. we should disable this by default.

AC

[x] When making a donation to an endaoment project there is no email received to the project owner.

divine-comedian commented 3 months ago

@maryjaf can you test this one since you are the project owner

maryjaf commented 3 months ago

When making a donation to an endaoment project there is no email received to the project owner.

Only for donation? or for example for changing status from admin also the email shouldn't be sent

divine-comedian commented 3 months ago

When making a donation to an endaoment project there is no email received to the project owner.

Only for donation? or for example for changing status from admin also the email shouldn't be sent

Only for donation - we should not be needing to change the status of the project from endaoment

divine-comedian commented 3 months ago

@maryjaf did this test pass then?

maryjaf commented 3 months ago

Yeah, The test passed I had donated to an endowment project and the project owner didn't receive any notification.

divine-comedian commented 2 months ago

@mohammadranjbarz if you can confirm this requirement is already active on production we can close this issue.

divine-comedian commented 2 months ago

We can test this issue on prod by this method

change project owner to tester address
donate to project
check if donation received email is sent
if no email is sent test passes
change project owner back to endaoment.eth

@mohammadranjbarz @maryjaf can test this together on PRODUCTION

divine-comedian commented 2 months ago

@maryjaf did we get a chance to test this?

maryjaf commented 2 months ago

@maryjaf did we get a chance to test this?

No, actually I tested this issue only on staging

divine-comedian commented 2 months ago

@maryjaf to provide mitch address so he can send test funds optimism to make donation on production

maryjaf commented 2 months ago

We can test this issue on prod by this method

change project owner to tester address

donate to project

check if donation received email is sent

if no email is sent test passes

change project owner back to endaoment.eth

@mohammadranjbarz @maryjaf can test this together on PRODUCTION

could you please change the project owner for one of the endaoment projects @mohammadranjbarz 0xcd192b61a8Dd586A97592555c1f5709e032F2505

maryjaf commented 2 months ago

@maryjaf to provide mitch address so he can send test funds optimism to make donation on production

Thanks @divine-comedian 0xA1179f64638adb613DDAAc32D918EB6BEB824104

maryjaf commented 2 months ago

The ownership of this project is changed to my address https://giveth.io/project/CARE-PERU
I've donated to this project and the project owner hasn't receive any notification and email related to this donation