Closed laurenluz closed 1 year ago
[x] Your history of notifications, starting with the most recent.
[ ] Can we change the sorting here? "All" "General" "My projects" "Supported projects" "Rewards" @MoeNick ? I don't like lumping together project activity for a projects owner & for a donor
@alireza-sharifpour can you take it?
@alireza-sharifpour can you take it?
Sure, I'll take it
I think @MoeNick wanted to do a bit of review on this @alireza-sharifpour ...
so if there are some suggestions that I made w/ a comment to @MoeNick, skip those until he gives the thumbs up
You can start te copy fixes @alireza-sharifpour There are some design changes that you can see on the Figma, jfyi on tabs and on setting page we added supported projects notification.
@MoeNick We get settings copies from the backend, so i think there would be some changes in the backend side. @mohammadranjbarz @CarlosQ96
I think we have to include it in related backend issue.
I assigned it to @mohammadranjbarz cause most of them need db changes
@laurenluz
About below question that you asked, yes we just send one notification per user-project to projectOwner, when someone likes/boosts a project
@maryjaf @MoeNick This issue has been implemented and merged you can test it here
https://notification-center-13.vercel.app/notifications/settings
- Your history of notifications, starting with the most recent.
In this section the old message is shown
- Important notifications outside of your settings may still be sent to you.
and this:
- "Send me an email" "Notify me in the DApp"
"Supported project updated" is duplicated
- Notify me only when GIV I staked for GIVpower gets unlocked. #31
Your history of notifications, starting with the most recent.
In this section the old message is shown
@maryjaf @MohammadPCh @alireza-sharifpour It's related to frontend
Important notifications outside of your settings may still be sent to you.
and this:
@maryjaf @MohammadPCh @alireza-sharifpour It's related to frontend
"Send me an email" "Notify me in the DApp"
@maryjaf @MohammadPCh @alireza-sharifpour It's related to frontend
"Supported project updated" is duplicated
@maryjaf Thanks for finding this, I deleted the repetitive one
- Notify me only when GIV I staked for GIVpower gets unlocked. Notify me only when GIV I staked for GIVpower gets unlocked. #31
Is this related to frontend or backend? @mohammadranjbarz
- Notify me only when GIV I staked for GIVpower gets unlocked. Notify me only when GIV I staked for GIVpower gets unlocked. #31
Is this related to frontend or backend? @mohammadranjbarz
No it's related to backend, thanks for mentioning that, I had forgotten about it, I added this comment
https://github.com/Giveth/notification-center/issues/31#issuecomment-1411604486
Thanks @alireza-sharifpour copy related to frontend has been edited
Ok, I have many copy suggestions for this page. I hope they are clear. I also added a few questions/change requests here. Lmk if anything doesn't make sense.
[x] Change your settings at any time to adjust how and when you see notifications. Important notifications outside of your settings may still be sent to you.
[x] "My Project Activity" "Notifications for project owners about project activity." ** need to confirm with @MoeNick & @mosaeedi that this design change is ok.
[x] "Send me an email" "Notify me in the DApp"
[x] "Project published" "Notify me when my project has been published."
[x] "Project updated" "Notify me when my project has been edited, or an update has been published."
[x] "Project liked" "Notify me when someone likes my project."
[x] "Project boosted" "Notify me when a new address boosts my project with GIVpower." @mohammadranjbarz - can you confirm that this notification occurs only for new addresses?
[x] "Project status" "Notify me when a project I own has been listed, unlisted, cancelled, activated or deactivated."
[x] "Donation received" "Notify me when my project receives a donation."
[x] #30
[x] "Supported project updated" "Notify me when a project I liked, boosted or donated to has an update." @MoeNick @mohammadranjbarz - can we confirm that we will make this change?
[x] "Donations" "Notify me when my donation to a project succeeds or fails."
[x] "Rewards" "Notifications related to GIV rewards and staking."
[x] "GIVbacks" "Notify me when my GIV from GIVbacks is ready to claim."
[x] #31
[x] Can we delete this one? I thought we decided not to do it
cc @maryjaf @MohammadPCh