Giveth / notification-center

It's a microservice that would handle all notification of giveth.io and trace.giveth.io
GNU General Public License v3.0
24 stars 2 forks source link

Notification Center - Copy Fixes & Some extra Changes.... #29

Closed laurenluz closed 1 year ago

laurenluz commented 1 year ago

Ok, I have many copy suggestions for this page. I hope they are clear. I also added a few questions/change requests here. Lmk if anything doesn't make sense.

cc @maryjaf @MohammadPCh

laurenluz commented 1 year ago
MohammadPCh commented 1 year ago

@alireza-sharifpour can you take it?

alireza-sharifpour commented 1 year ago

@alireza-sharifpour can you take it?

Sure, I'll take it

laurenluz commented 1 year ago

I think @MoeNick wanted to do a bit of review on this @alireza-sharifpour ...

so if there are some suggestions that I made w/ a comment to @MoeNick, skip those until he gives the thumbs up

MoeNick commented 1 year ago

You can start te copy fixes @alireza-sharifpour There are some design changes that you can see on the Figma, jfyi on tabs and on setting page we added supported projects notification.

alireza-sharifpour commented 1 year ago

@MoeNick We get settings copies from the backend, so i think there would be some changes in the backend side. @mohammadranjbarz @CarlosQ96

MoeNick commented 1 year ago

I think we have to include it in related backend issue.

MoeNick commented 1 year ago

I assigned it to @mohammadranjbarz cause most of them need db changes

mohammadranjbarz commented 1 year ago

@laurenluz

About below question that you asked, yes we just send one notification per user-project to projectOwner, when someone likes/boosts a project

Screen Shot 1401-11-05 at 11 01 40
mohammadranjbarz commented 1 year ago

@maryjaf @MoeNick This issue has been implemented and merged you can test it here

https://notification-center-13.vercel.app/notifications/settings

maryjaf commented 1 year ago
  • Your history of notifications, starting with the most recent.
image

In this section the old message is shown

maryjaf commented 1 year ago
  • Important notifications outside of your settings may still be sent to you.

and this:

image
maryjaf commented 1 year ago
  • "Send me an email" "Notify me in the DApp"
image
maryjaf commented 1 year ago
image

"Supported project updated" is duplicated

maryjaf commented 1 year ago
  • Notify me only when GIV I staked for GIVpower gets unlocked. #31
image
mohammadranjbarz commented 1 year ago

Your history of notifications, starting with the most recent.

image

In this section the old message is shown

@maryjaf @MohammadPCh @alireza-sharifpour It's related to frontend

mohammadranjbarz commented 1 year ago

Important notifications outside of your settings may still be sent to you.

and this: image

@maryjaf @MohammadPCh @alireza-sharifpour It's related to frontend

mohammadranjbarz commented 1 year ago

"Send me an email" "Notify me in the DApp"

image

@maryjaf @MohammadPCh @alireza-sharifpour It's related to frontend

mohammadranjbarz commented 1 year ago
image

"Supported project updated" is duplicated

@maryjaf Thanks for finding this, I deleted the repetitive one

maryjaf commented 1 year ago
image

Is this related to frontend or backend? @mohammadranjbarz

mohammadranjbarz commented 1 year ago
image

Is this related to frontend or backend? @mohammadranjbarz

No it's related to backend, thanks for mentioning that, I had forgotten about it, I added this comment

https://github.com/Giveth/notification-center/issues/31#issuecomment-1411604486

maryjaf commented 1 year ago

Thanks @alireza-sharifpour copy related to frontend has been edited