search

Giveth / notification-center

It's a microservice that would handle all notification of giveth.io and trace.giveth.io
GNU General Public License v3.0
24 stars 2 forks source link

Improve seedNotificationType #7

Closed mohammadranjbarz closed 1 year ago

mohammadranjbarz commented 1 year ago

related to #6 @CarlosQ96

We had to add some HTML templates as https://gist.github.com/MohammadPCh/24434d50bc9ccd9b74905c271ee05482 so after merging we should delete some tables and migrations, to seed them again in staging DB, I added something to validate notificaiton's metadata as you wrote for segment data, and wrote lots of test cases to cover all notification types.

PS After this we should change impact-graph to send needed metadata when sending notifications and maybe calling notification-center in more places like when someone like a project

mohammadranjbarz commented 1 year ago

@CarlosQ96 Thanks for your great review and made changes