search

Giveth / vaultcontroller

Vault Architecture
GNU General Public License v3.0
0 stars 3 forks source link

Magic numbers #12

Closed adria0 closed 7 years ago

adria0 commented 7 years ago

Consider change 86400 for 24 hours

jbaylina commented 7 years ago

As the contract always works in seconds, I lite to put this in seconds too.

GriffGreen commented 7 years ago

I like seconds (make 24 hours a comment)

dipenjoshi commented 7 years ago

seconds its is.

adria0 commented 7 years ago

hours is a solidity emeeded alias for 3600 since solidity works always with seconds. So we still will be working with seconds.