search

Giveth / vaultcontroller

Vault Architecture
GNU General Public License v3.0
0 stars 3 forks source link

Rename primaryVault and topUpVault #17

Open adria0 opened 7 years ago

adria0 commented 7 years ago

Since there's no secondary vaults, consider renaming primaryVault property to vault Consider renaming topUpVault() to topUpCallerVault()

jbaylina commented 7 years ago

@GriffGreen ^^

GriffGreen commented 7 years ago

I think there needs to be a qualifier in front of vault because there are so many vaults.

The primaryVault is special because it is generated first and has no parentVault (which should be renamed to overflowDestination I guess thats a different issue)

If you dont like primaryVault how about genesisVault @adriamb

https://youtu.be/qOyF4hR5GoE?t=24s

ghost commented 7 years ago

I like these:

genesisVault originVault sourceVault rootVault masterVault alphaVault ownerVault startingVault firstVault progenitorVault

GriffGreen commented 7 years ago

@jbaylina I like primaryVault = genesisVault :-D @adriamb was calling it rootVaultthats not too bad either if you don't like genesis... but I like the crypto-ish genesisreference.

@daniphilia what do you think about changing parentVault to overflowDestination? any better words?

ghost commented 7 years ago

masterDelegate?tokenShepherd?fundShepherd?:

the masterDelegate* is the shepherd of the initial fund of tokens, issuing the fund to the root node of the family tree, and acting as the resolver of all sorts of conflicts, including: fund overflows, cancelled funds, etc.