search

Giveth / vaultcontroller

Vault Architecture
GNU General Public License v3.0
0 stars 3 forks source link

2 comments and 43 name changes :-) #2

Closed GriffGreen closed 7 years ago

GriffGreen commented 7 years ago

A couple of comments:

sendBackOverflow needs to be checked... or explained to me... it seems like it only works for the primary vault...?

The Cancel projects stuff doesn't make sense... I'm excited to see what it looks like once you attack it :-)

SO MANY NAME CHANGES

  1. ProjectController = VaultController

  2. activationTime = timeLockExpiration

  3. dailyLimit = dailyValueLimit

  4. dailyTransactions = dailyTxnLimit

  5. transactionLimit = txnValueLimit

  6. startHour = openingTime

  7. endHour = closingTime

  8. addr2recipient = addr2recipientID

  9. addr2spender = addr2spenderID

    1. childProjects = childVaultControllers

  10. addr2project = addr2VaultControllerID

  11. parentProjectController = parentVaultController

  12. mainVault = primaryVault

  13. projectControllerFactory = vaultControllerFactory

  14. topThreshold = highestAcceptableBalance

  15. bottomThreshold = lowestAcceptableBalance

  16. maxDailyLimit = maxDailyValueLimit

  17. maxDailyTransactions = maxDailyTxnLimit

  18. maxTransactionLimit = maxTxnValueLimit

  19. maxTopThreshold = maxHighestAcceptableBalance

  20. createProject = createVaultController

  21. cancelChildProject = cancelChildVault

  22. cancelProject = cancelVault

  23. setProjectParams = setVaultLimits

  24. refillMe = topUpVault

  25. idProject = idVault

  26. projectBalance = vaultBalance

  27. newPayment = sendToAuthorizedRecipient

  28. unauthorizeSpender = removeAuthorizedSpender

  29. unauthorizeRecipient = removeAuthorizedRecipient

  30. actualHour = actualTime

  31. timeSinceStart = timeSinceOpening

  32. numberOfProjects = numberOfVaults

  33. event AuthorizedRecipient = RecipientAuthorized

  34. event UnauthorizedRecipient = RemoveAuthorizedRecipient

  35. uint indexed idSpender, address indexed recipient = uint indexed idRecipient, address indexed recipient

  36. event AuthorizeSpender = SpenderAuthorized

  37. event UnauthorizeSpender = RemoveAuthorizedSpender

  38. event NewProject = NewVault

  39. event ProjectCanceled = VaultCanceled

  40. event ProjectRefill = TopUpVault

  41. event ParamsChanged = VaultLimitsChanged

  42. contract ProjectControllerFactory = VaultControllerFactory

jbaylina commented 7 years ago

Done!