cancelling a root vault causes owner == 0 [?]

Giveth / vaultcontroller

Vault Architecture

GNU General Public License v3.0

0 stars 3 forks source link

cancelling a root vault causes owner == 0 [?] #40

Open adria0 opened 7 years ago

adria0 commented 7 years ago

Since parentVaultController is 0 in root vault, he ower is changed to 0. ( btw, maybe we need to use Owned.changeOwner ?? )

    function cancelVault() onlyOwnerOrParent returns (bool _finished) {
      ...
    owner = parentVaultController;

Is setting owner == 0 an usual behavior?

GriffGreen commented 7 years ago

wow! Nice catch, it is usual behavior if you want to decentralize your vault... the owner can be set to 0.... but for cancelling the vault, that may not be what we want.