search

GiviMAD / whisper-jni

A JNI wrapper for using whisper.cpp, allows to transcribe speech to text in Java.
Apache License 2.0
81 stars 12 forks source link

update to work with android #23

Open kaisoapbox opened 3 months ago

kaisoapbox commented 3 months ago

See #19 - the java.nio.file.Files.readString method is not supported in android for whatever reason, but the Java 8 version of the equivalent functionality is, and so I've replaced usages of the readString method which would work similarly.

I'm not sure if this commit works with your CI (e.g. versioning, etc), so I'll leave changing that up to you if this change works!

GiviMAD commented 3 months ago

One question out of the ignorance, is that enough to make it work with android? I'll try to merge it tomorrow, thank you for the PR.

kaisoapbox commented 3 months ago

honestly im not 100% sure because im not super experienced with java and the android ecosystem too, ill keep trying to fiddle with it to get it working if this PR isn't sufficient

kaisoapbox commented 2 months ago

@GiviMAD can you pls merge my PR sir 🥺

kaisoapbox commented 2 months ago

nevermind - I think I realized that it wouldn't work with android either way because you'd likely have to build .so files for a couple additional architectures, and I'm not sure it's straightforward to do so? It's definitely doable, but there's definitely more steps involved to make this work for android