GizmoTheMoonPig / luggage

Recreation of OpenBlocks luggage for modern MC versions
MIT License
3 stars 2 forks source link

Memory leak in fabric 1.19 version #10

Closed m-m-0-0 closed 1 year ago

m-m-0-0 commented 2 years ago

I'm running a fabric server with a few (20-30) mods installed, and I'm running into some memory leak problems in the client. I traced it back to this mod using Spark. I also tried to start a single player world with only this mod, its dependencies and spark installed, and it's exibithing the same behaviour.

I don't have any clear step to reproduce this, but what I do is spawn some Luggages, fill them up with some stuff, pick them up, throw the item to the ground and spawn a couple of them again. This seems to always use up all the available JVM memory in a few minutes.

here's a spark heapsummary made right when it starts lag spiking: https://spark.lucko.me/hx5GFp8ftE

installed mods:

let me know if you need additional information, thanks!

GizmoTheMoonPig commented 2 years ago

Thank you for reporting this, we'll look into a fix as soon as we can. In the meantime, would you be willing to test the forge version as well? I'm curious if this is an issue on both versions or just fabric. I would do it myself but I'm gonna be unavailable for a little bit

m-m-0-0 commented 2 years ago

Sure! I'll get to it as soon as I got some time.

m-m-0-0 commented 2 years ago

Doesn't seem to happen in Forge here's the spark heapsummary after about 20 minutes, tried to recreate the same conditions as in the fabric one roughly: https://spark.lucko.me/9MpB0GsE6G

hope this helps!

GizmoTheMoonPig commented 2 years ago

Awesome, really glad to hear this isn't an issue on both versions. One last thing before we can go about debugging this correctly, what mods were you playing with on fabric? Was it just the 3 you mentioned initially, or did you have other mods loaded up as well? I'll need a whole list if there's any others. We want to identify any possible mod conflicts and fix those if it's not just the mod itself acting up.

m-m-0-0 commented 2 years ago

So, I noticed the issue while playing with these mods installed (luggage currently removed): image

Then I tried just leaving the three mods I mentioned in the first post and the problem remained, so I don't suppose it's a mod conflict.

AlphaMode commented 2 years ago

Can you try the latest version I think it might possibly fix it

GizmoTheMoonPig commented 1 year ago

Gonna assume this is no longer an issue since I havent heard anything about it. If its still a problem let me know, I take stuff like this very seriously. Thanks for reporting!