search

GizmoTheMoonPig / luggage

Recreation of OpenBlocks luggage for modern MC versions
MIT License
3 stars 2 forks source link

Whistle has no concurrency detection #13

Closed BrainSlugs83 closed 1 year ago

BrainSlugs83 commented 2 years ago

Holding down the whistle key for a second (because it can take a second for the whistle to happen... so it just seems natural)... can cause like 100 whistles to all happen at once... -- it feels like this causes some frame drops too when it happens.

I suggest adding some kind of concurrency detection (i.e. ignore the whistle key until the whistle is over -- that way if you hold it down, it will still whistle over and over... but not 100 whistles all at once).

GizmoTheMoonPig commented 2 years ago

Which version are you playing on? I fixed the whistle spam back in the 1.18 version, should be on 1.19 as well.

BrainSlugs83 commented 2 years ago

In MultiMC it says the version is "NONE". For Minecraft, I'm using 1.19. The MD5 hash of the file I downloaded matches this one, so I guess I'm using 1.4.2: image

BrainSlugs83 commented 2 years ago

This is also happening in 1.4.3 (Fabric).

GizmoTheMoonPig commented 2 years ago

oh its because the fix isnt on fabric. I'll get in touch with the fabric maintainer, and we'll get that fixed soon

GizmoTheMoonPig commented 1 year ago

Should be fixed in the latest fabric version. Let me know if it isn't and we'll get it fixed