Gizra / Municipality

https://dev-municipality.pantheonsite.io/
1 stars 0 forks source link

fix weekly recurring events date display [4h] #540

Open noamoss opened 7 years ago

noamoss commented 7 years ago

This is a weekly recurring event. When we check it following the first date, it becomes irrelevant.
image

Expected behavior:

when an event is recurring, hide the start date on the

noamoss commented 7 years ago

@liatsade see the problem described. I am thinking of not showing the date, just the day name, on recurring events to solve this. What do you think? any other idea?

liatsade commented 7 years ago

@noamoss yes, hide the date in weekly events sounds right.

nedSaf commented 7 years ago

@noamoss This also relates to #538, we can't remove the date and the day, I think we should add a day when the event ends on a different day.

noamoss commented 7 years ago

@nedSaf As I wrote on #538 I would prefer that, as long as we can make sure the output string does not break in the middle of day 1 or day 2. A link break should be used only in between (following the '-').

On recurring events, the only other (and more complicated) option would be updating the displayed date according to the current date. As I really don't want to invest time on it for now, the day name (without date is preferable to display.

nedSaf commented 7 years ago

@noamoss Let's discuss tomorrow.

nedSaf commented 7 years ago

What's going to be done:

  1. Remove the date.
  2. Keep the day and hour.
  3. Change the upcoming events filtering to the end date. related to #331
  4. Display recurring events at the beginning of the events list.
nedSaf commented 7 years ago

@noamoss Please add another hour for the new sorting.

savyoncohen commented 7 years ago

@noamoss Fixed on all 4 pages: homepage, events, topics and single events page: selection_999 041 selection_999 042 selection_999 043 selection_999 044