search

Gizra / Municipality

https://dev-municipality.pantheonsite.io/
1 stars 0 forks source link

Auto populate and hide group audience field from editor's views [3h] #584

Open savyoncohen opened 6 years ago

savyoncohen commented 6 years ago

selection_065

I'm getting this error when trying to create the content : image

savyoncohen commented 6 years ago

@noamoss I found this bug, please add time boxing and assign.

nedSaf commented 6 years ago

@noamoss Editors shouldn't be able to choose a group, we are going to hide this field in the future, maybe it's worth changing the issue to make prepopulated and hide it.

nedSaf commented 6 years ago

Instead of fixing it and then hiding it.

noamoss commented 6 years ago

@nedSaf

we are going to hide this field in the future, maybe it's worth changing the issue to make prepopulated and hide it.

I agree, but it should be a wider (for all CT) issue, not just for the HardCopyForm. Do I get it right?

nedSaf commented 6 years ago

Yeah, for sure.

noamoss commented 6 years ago

done

nedSaf commented 6 years ago

Removed bug label as well.

savyoncohen commented 6 years ago

@noamoss The field is auto populated for all content types, but not hidden from the user.

image

nedSaf commented 6 years ago

@savyoncohen Sorry forgot to enable the new module, please check again now.

savyoncohen commented 6 years ago

@nedSaf I'm getting this message. How am I suppose to get the muni in the url?

image

nedSaf commented 6 years ago

@savyoncohen

  1. You need to test this as an editor, not admin (more accurate results)
  2. You need to go to the homepage and select your Muni, the og_context works when the muni is the purl. (you have to be an editor on that muni).
savyoncohen commented 6 years ago

@nedSaf I'm not admin, all my tests are with my editor user: savyon, 1234 I try to go from here: http://test-municipality.pantheonsite.io/municipality-4/node/4?language=en and click on add content from the menu. It's doesn't work...

selection_120

nedSaf commented 6 years ago

@savyoncohen That's another issue that @noamoss and I discussed already and we need to add links for editors to add content, this issue is about the field.

Please go to: http://test-municipality.pantheonsite.io/municipality-4/node/add/action?language=he

for example and test this issue. (or any other content type).

noamoss commented 6 years ago

@savyoncohen Nader is referring to https://github.com/Gizra/Municipality/issues/461#issuecomment-342821805.

Meanwhile please follow his last link and approve the hiding part has been implemented correctly.

savyoncohen commented 6 years ago

@noamoss When adding a node from the muni main page, the group audience field is hidden and I don't get any error :+1: . I checked for all content types. image