search

Gizra / Municipality

https://dev-municipality.pantheonsite.io/
1 stars 0 forks source link

WIP: Add Skip-To module. #592

Open nedSaf opened 6 years ago

nedSaf commented 6 years ago

362

nedSaf commented 6 years ago

@noamoss @liatsade Installed the module and it was a hassle because it needed a library which didn't specify how to get that library, in any case, I added some custom code to install it.

some weird things about this module though:

  1. Can't get the configuration page for the module.
  2. The texts in the menu come only from a JS file which means, it can't be translated.

skip-to skipto-dropdown

TimeBox: 1.5/3

nedSaf commented 6 years ago

I saw that some Israeli sites are using an accessibility plugin which covers everything we need instead of keep adding custom code to everything, maybe worth having a look at that.

noamoss commented 6 years ago

@nedSaf last time we surveyed the options (...guess in which project) we realized they are commercial add-ins with problematic usage licenses. If you know/saw any specific plugin, send it t me and I will check it. Otherwise, I prefer not to invest more time in this investigation.

nedSaf commented 6 years ago

@noamoss Alright, I think this JS file is good enough, I just think I'll remove the Drupal module because it's not doing anything really.

noamoss commented 6 years ago

@nedSaf

but you wrote that

The texts in the menu come only from a JS file which means, it can't be translated.

does it means that the accessibility method won't fit no-default language? (so Arabic speaking person will have to know to Hebrew to navigate through the site?)

nedSaf commented 6 years ago

No, I mean the labels from the module itself won't be translated and will be always in English, the content will be according to the user's language.

noamoss commented 6 years ago

great 👍