search

Gizra / elm-hedley

Elm web app with Headless Drupal backend
https://gizra.github.io/elm-hedley
MIT License
307 stars 36 forks source link

Port to v0.18 #145

Open amitaibu opened 8 years ago

amitaibu commented 8 years ago

Waiting for https://github.com/rgrempel/elm-route-hash/issues/13#issuecomment-224367690

michallepicki commented 7 years ago

I would love to see this ported to v0.17. Looks like a great learning resource!

amitaibu commented 7 years ago

Indeed, just missing some time. Hopefully will get it going soon with other Gizra devs.

DavidHernandez commented 7 years ago

I'm working on this. elm-route-url already supports 0.17 and there are no more blocking dependencies.

@amitaibu, if you give me access to the repo I will push a new branch with my current changes so anyone else can contribute.

DavidHernandez commented 7 years ago

There are some packages that were not being handled using the elm package manager, instead they are directly on a vendor folder. One of them at least, is not going to be upgraded to 0.17: https://github.com/rgrempel/elm-web-api/issues/17

I'm investigating if this vendor is really necessary or if we can get rid of it.

michallepicki commented 7 years ago

Only Location seems to be used, so that should be easy. I found two modules that are using it: Config/Update.elm and Pages/GithubAuth/Update.elm

lisardo commented 7 years ago

@DavidHernandez did you have any progress? I would love to see a port to 0.17!

DavidHernandez commented 7 years ago

Not really, and I actually lost some of the progress as my laptop was stolen :(

I will try to allocate some time during the next few weeks to work on this.

DavidHernandez commented 7 years ago

I'm starting to work on this again. Following the original proposal from @amitaibu, I've removed everything I will start from the begining. All the work will be done on the same PR, on this branch from my fork: https://github.com/DavidHernandez/elm-hedley/tree/0.17-upgrade

I will go replicating each of the existing pages. I already started with the login. If anyone wants to help, just fork my repo and do PRs.

amitaibu commented 7 years ago

👍

DavidHernandez commented 7 years ago

As 0.18 has been released, so we will go directly for the 0.18 upgrade.

nedSaf commented 7 years ago

@DavidHernandez What's the status on this ? Do you need any help ?

DavidHernandez commented 7 years ago

@nader77 right now there is only one vendor library left with no support for elm 0.18 and it is https://github.com/rgrempel/elm-route-url

I will open an issue on that repository about upgrading to 0.18.

amitaibu commented 7 years ago

There's already a PR for that -- https://github.com/rgrempel/elm-route-url/pull/19

DavidHernandez commented 7 years ago

By the way, to work with different versions of Elm, there is this npm module that does a nice job: https://www.npmjs.com/package/elm-version-manager