search

Gizra / kaveret7

Kaveret D7 codebase
0 stars 0 forks source link

Enable mcapi_signatures, to allow payment workflow #143

Open barochoren opened 11 years ago

barochoren commented 11 years ago

Issue Summary:

Original: התנהגות רצויה: בתשלום שאני מבצע אל חבר, אין צורך באישור החבר. הוא פשוט מקבל כסף. בתשלום שבו אני מחייב את חשבונו של חבר, יש צורך באישור החבר לפני ביצוע העסקה

התנהגות מצויה: בשני הכיוונים העסקאות יוצאות לפועל (מגיעות למצב CLEARED) ללא כל בקשת אישור מצד ב' לעסקה.

התוצאה: אני יכול לקחת כסף ממי שאני רוצה)

amitaibu commented 11 years ago

@shlomilahav, This is taken care of by mcapi_signatures module, probably enough just to enable it.

Screenshot_4_10_13_12_24_PM

amitaibu commented 11 years ago

mcapi-singatures needs some love...

btw, add module_load_include('inc', 'mcapi', 'mcapi'); in mcapi_tokens() to prevent WSOD.

amitaibu commented 11 years ago

No option to accept/ deny payment due to bug upstream -- http://drupal.org/node/1966482

However, for now we can add the Pending transactions to the top of the page.

niryariv commented 11 years ago

@barochoren note^^

barochoren commented 11 years ago

body p { margin-bottom: 0cm; margin-top: 0pt; } I'm contacting matthew on that, I'll update as soon as I get new info.

barochoren commented 11 years ago

mat says:

-------- Original Message -------- Subject: Re: please try to see how much effort is needed to fix amitai's bug Date: Wed, 10 Apr 2013 13:12:37 -0500 From: Matthew Slater matslats@gmail.com To: Baroch Oren Computer Engineering ברוך אורן הנדסת מחשבים 0523-563147 info@barochoren.com CC: Arie Ben David abdalma@gmail.com, Amitai Burstein amitai@gizra.com

no this was a simple matter of a bit of code i forgot to update after a major refactor I did in Israel, actually. Instead of providing a 'sign here' link, each transaction now has 'operations', which are declared in a hook. thus the signatures module provides the 'sign' and 'sign off' operations, while mcapi itself provides the views field called 'operations'. Amitai only needs to use a different views field than the one provided in the default view. I have corrected the default view, but not pushed the code up yet. Matthew

@amitaibu

barochoren commented 11 years ago

I don't get it, does matthew's answer advance us? or are we still stuck without the ability to approve pending transactions? (which would be a showstopper?) @amitaibu @niryariv

amitaibu commented 11 years ago

I have corrected the default view, but not pushed the code up yet.

I've assumed he's going to push the code and let us know -- that would probably be faster. If you want we can investigate and find the new solution.

amitaibu commented 11 years ago

Lets change the view field.

amitaibu commented 11 years ago

@shlomilahav , the views fields you want to add is 'operations' in the group 'transactions'

shlomilahav commented 11 years ago

m1

matslats commented 11 years ago

Hi to get the operations to show you have to set per-operation permissions per-currency. Edit the currency and see the vertical tab. I don't see any other open issues from here on this thread...