Gizra / kaveret7

Kaveret D7 codebase
0 stars 0 forks source link

HIGH: right-sidebar when selection is empty should suggest creating new content #186

Closed barochoren closed 11 years ago

barochoren commented 11 years ago

See attached as the vision and the design for the right-sidebar.

THIS SIDEBAR SHOULD REPLACE THE CURRENT (VACANT/DYNAMIC) SIDEBAR, so as user logs into the site - he can see the "you haven't ..." notice and he can see the relevant "create new" links.

Note that the TBD are future expansions, when we reach the relevant stage.

Block-manager admin should be able to add custom links as seen.

notice that all blue items are links, that should become underlined as hovered.

right-sidebar facebook-add

barochoren commented 11 years ago

@niryariv

niryariv commented 11 years ago

@barochoren this is in all pages of the site? do u have a design for this?

barochoren commented 11 years ago

body p { margin-bottom: 0cm; margin-top: 0pt; } yes, all places in this site for logged-in users design has been attached to the issue. @NIR.YARIV

niryariv commented 11 years ago

@barochoren by design I mean what it should look like on the finished site. If you don't have it we'll work with what we got, but keep in mind this usually results in "design fixes" tickets down the line which require more developer hours in turn.

niryariv commented 11 years ago
barochoren commented 11 years ago

this image is the 99% ready design. there would be no "design fixes" down the line if you stick to it :-) see these remarks:

right-sidebar @niryariv

niryariv commented 11 years ago

@barochoren re: "THIS SIDEBAR SHOULD REPLACE THE CURRENT (VACANT/DYNAMIC) SIDEBAR" - which sidebar exactly? can you provide a screenshot with the sidebar that needs to be replaced?

bricel commented 11 years ago

https://gist.github.com/bricel/2ce5b11b2f6aeb38e068

barochoren commented 11 years ago

186b @niryariv

niryariv commented 11 years ago

@bricel @shlomilahav see above ^ - the new sidebar replaces "My Content"

barochoren commented 11 years ago

some remarks on the pull request's code: @niryariv -- [ ] this block should replace the old "my content" block, whereas the pull request's attached image (https://f.cloud.github.com/assets/3906951/420077/df8aca18-ace5-11e2-8f62-5ca4c6d64d49.png) shows them both...

+  $output = '<h3>' . t('My Offers') . '</h3>' . theme('item_list', array('items' => $items['offer'])) . l(t('+ Create a new offer'),'node/add/offer');
+  $output .= '<h3>' . t('My Requests') . '</h3>' . theme('item_list', array('items' => $items['request'])) . l(t('+ Create a new  request'),'node/add/request');
+  $output .= '<h3>' . t('My Groups') . '</h3>' . theme('item_list', array('items' => $items['community'])) . l(t('+ Create a new group'),'node/add/community');
niryariv commented 11 years ago

@barochoren I think this is what I was referring to when I asked for a design to prevent "design fixes" tickets down the line..

niryariv commented 11 years ago

@shlomilahav looks good! Text corrections - add "s" to offer/request - ie, make it plural instead of singular. The text should be:

"You haven't created any offers yet" "You haven't created any requests yet"