search

Gizra / message_notify

https://www.drupal.org/project/message_notify
11 stars 17 forks source link

Simple integration with Slack module. #43

Closed mccrodp closed 7 years ago

mccrodp commented 7 years ago

Here is some initial work on Slack integration for review.

It is a simple notifier plugin that sends the Slack Body view mode to a Slack channel (via Webhook URL) set in the Slack module config UI below.

slack-module-config

Drupal Message: message-data-test

Slack Message sent via Message Notify: message-data-slack-test

amitaibu commented 7 years ago

I think it would make more sense to (try) to provide it as a patch to the Slack module. What do you think?

mccrodp commented 7 years ago

Ok, can take a look, but not sure I follow. Any more info or suggestion? It needs to be a notifier plugin to integrate with it though, it needs to be trigger from message_notify side? I just cloned the way it was for SMS plugin, any example of the other way around that you're suggesting?

amitaibu commented 7 years ago

I mean, move the plugin from this module, to the slack module.

jhedstrom commented 7 years ago

Other modules can provide message_notify plugins (in both Drupal 7 and 8). For instance, this module https://www.drupal.org/project/message_digest does that.

mccrodp commented 7 years ago

Thank you, will take a look at this tomorrow :)

mccrodp commented 7 years ago

It is done https://www.drupal.org/node/2845248 👷 😃

jhedstrom commented 7 years ago

Great!