search

Gizra / message_notify

https://www.drupal.org/project/message_notify
11 stars 17 forks source link

Clarify ambiguous wording in exception message #62

Closed pfrenssen closed 6 years ago

pfrenssen commented 6 years ago

This is a minor improvement to one of the exception messages. I was confused about this wording:

It is not possible to send a Message for an anonymous owner.

The "for" seems to indicate that the anonymous user is the sender of the message, not the recipient. This is reinforced by the fact that it checks $message->getOwner() - in many other entity types the owner is the same as the author, but this is not the case for messages.

I propose to change it so it is clear the message is attempted to be sent TO an anonymous user.

jhedstrom commented 6 years ago

This is much better :) Thanks!