Remove AccessField - Githubissues

Gizra / og

https://www.drupal.org/project/og

92 stars 133 forks source link

Remove AccessField #508

Open pfrenssen opened 5 years ago

pfrenssen commented 5 years ago

In Drupal 7 a group could be configured to have different permissions than the permissions defined by default. This information was stored in a field. This field has been ported to Drupal 8 but it was never used. If we want to port this functionality it should not be stored in a field but rather in the group entity's third party settings.

Remove the AccessField class.
Remove the defined constant OG_DEFAULT_ACCESS_FIELD.
Remove any test coverage related to this field in FieldCreateTest.

amitaibu commented 5 years ago

Thanks. For a bit more context:

if we want to port this functionality

Eventually we probably should, as I know of sites using it in D7.

it should not be stored in a field but rather in the group entity's third party settings.

The use of a configurable field was mostly to allow easier Views integration.

pfrenssen commented 5 years ago

OK this is good to know, we should do an evaluation of what would be the best approach in Drupal 8 that would address the various use cases.