search

Gizra / public_education

http://gizra.github.io/public_education/
2 stars 1 forks source link

When looping through locations remember the placemark panel state #137

Closed mushon closed 10 years ago

mushon commented 10 years ago

If the user chose to fold the panel, keep it folded.

(this is important towards the launch)

amitaibu commented 10 years ago

Please explain (what it placemark panel state)

mushon commented 10 years ago

I mean the << > >> with the text and flag and all

Mushon Zer-Aviv Mushon.com (http://Mushon.com) | Shual.com (http://Shual.com) | @Mushon (http://twitter.com/mushon)

On Monday, November 4, 2013 at 2:25 PM, Amitai Burstein wrote:

Please explain (what it placemark panel state)

— Reply to this email directly or view it on GitHub (https://github.com/Gizra/public_education/issues/137#issuecomment-27681404).

amitaibu commented 10 years ago

The panel is folded by default. When you cycle through all the markers via web, it will keep it open. Do you want another behaviour?

mushon commented 10 years ago

Yes, If I started the cycle and then folded the panel it should maintain its state in the following markers as well.

Mushon Zer-Aviv Mushon.com | Shual.com | @Mushon

On Nov 4, 2013, at 14:38, Amitai Burstein notifications@github.com wrote:

The panel is folded by default. When you cycle through all the markers via web, it will keep it open. Do you want another behaviour?

— Reply to this email directly or view it on GitHub.

mushon commented 10 years ago

I cannot see this in the latest merge into gh-pages, are you sure it's there? It opens for me the panel opens with every new marker. Please check again, reopening.

amitaibu commented 10 years ago

Current logic is to always keep open on cycle. Change it?

‫ב-6 בנוב 2013, בשעה 16:24, ‏Mushon Zer-Aviv notifications@github.com כתב/ה:‬

Reopened #137.

— Reply to this email directly or view it on GitHub.

mushon commented 10 years ago

Yes, the logic should be to always maintain the latest state the user asked (whether open or closed)

Mushon Zer-Aviv Mushon.com (http://Mushon.com) | Shual.com (http://Shual.com) | @Mushon (http://twitter.com/mushon)

On Wednesday, November 6, 2013 at 6:36 PM, Amitai Burstein wrote:

Current logic is to always keep open on cycle. Change it?

‫ב-6 בנוב 2013, בשעה 16:24, ‏Mushon Zer-Aviv <notifications@github.com (mailto:notifications@github.com)> כתב/ה:‬

Reopened #137.

—
Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub (https://github.com/Gizra/public_education/issues/137#issuecomment-27889215).

amitaibu commented 10 years ago

Pushed fix to gh-pages.