search

GjjvdBurg / ffcount

Fast File and Directory Counting in Python
Apache License 2.0
10 stars 2 forks source link

Does using the win32 API improve performance measurably? #14

Open ChristopherSchultz opened 2 years ago

ChristopherSchultz commented 2 years ago

Not actually an issue, just a question, but Discussions aren't enabled for this repository.

If there are some significant gains, please file a PR against my original repo and I'll merge it.

GjjvdBurg commented 2 years ago

Thanks for raising this issue @ChristopherSchultz, it's a good question!

Unfortunately, as it's been a few years since I made that change, I'm not really clear on the reason why. I vaguely recall that using the builtin functions may have been easier to compile, but I can't be sure. I also no longer have a Windows machine, so I won't be able to do test this empirically.

I''m happy to leave this issue open in case anyone wants to do that investigation though.

ChristopherSchultz commented 2 years ago

I also no longer have a Windows machine

Congratulations :)

ChristopherSchultz commented 2 years ago

In all seriousness, I tend to favor minimizing code complexity whenever possible. If there is a good reason to have what amounts to two separate implementations of the ffcount core code (std C vs win32), I'm happy to support them both. But my default position would be to just have the one implementation for simplicity.