search

GjjvdBurg / paper2remarkable

Fetch an academic paper or web article and send it to the reMarkable tablet with a single command
MIT License
336 stars 27 forks source link

URL regex fails for valid URL #151

Open Barabazs opened 1 month ago

Barabazs commented 1 month ago

The current regex fails to validate 'https://hackmd.io/@abdelhamid/ethereum-alignment' as a valid URL.

I would suggest to replace the regex with a library like https://validators.readthedocs.io or fix the regex pattern. It might also be a good idea to add a --source=url type of option in the CLI.

PS: I can create a PR if you agree.

GjjvdBurg commented 1 month ago

Thanks for reporting this @Barabazs! Both of those sound like great ideas, and I'd welcome your PR!