Closed ericthegrey closed 3 years ago
As an aside, I noticed that the time and checkmarks on my messages are left-aligned instead of right-aligned as it is in the app. I can take a look at that once we sort this PR out.
I find it slightly distracting and I'm not sure how accurate it is (I have one group with 6 people including myself, and there's a message with a count of 7).
I suppose this comes from some people having multiple linked devices, but I'm not sure. Well, since the usefulness is limited, I will remove it. At some point we can have a hover of all group members who have been sent/been delivered/read the message.
What would you think about showing this info on hover, or making it optional using a command line flag?
Okay, thanks! This looks good to me so can be merged when you're ready :+1:
Just out of curiosity I was playing around with the double checkmarks, and I found that there is a letter-spacing
html property that we could use to reduce the spacing between them. It could work like this:
diff --git a/signal2html/templates/thread.html b/signal2html/templates/thread.html
index 375e3d5..3dfada1 100644
--- a/signal2html/templates/thread.html
+++ b/signal2html/templates/thread.html
@@ -34,7 +34,7 @@
{% elif state == "DISPLAY_TYPE_FAILED" %}
⚠{# Warning sign #}
{% elif state == "DISPLAY_TYPE_DELIVERED" %}
- ✓✓{# Double checkmark #}
+ <span class="double-checkmarks">✓✓</span>{# Double checkmark #}
{% elif state == "DISPLAY_TYPE_READ" %}
✓✓✓{# Triple checkmark #}
{% endif%}
@@ -144,6 +144,10 @@
width: 400px;
}
+ .double-checkmarks {
+ letter-spacing: -0.3em;
+ }
+
.msg-img-container input[type=checkbox] {
display: none;
}
Would that be a nice addition you think? Feel free to merge this PR as you see fit!
Just out of curiosity I was playing around with the double checkmarks, and I found that there is a
letter-spacing
html property that we could use to reduce the spacing between them. It could work like this:[...]
Would that be a nice addition you think? Feel free to merge this PR as you see fit!
Hi @GjjvdBurg !
I tried it on Firefox and the result appears to chop the checkmarks:
So I added some margins as well. (You'd think adding it on the right side should suffice, but no, left side is decisive.)
Thanks for merging this btw! Nice fix on the double checkmarks, I think it looks great now :)
This PR adds more information to each message:
I also added code to display failed messages and in-progress messages but I've not seen them in any backup.
This PR is over the bugfix/rid_not_found branch so that should be committed first. I think with this code, we're now showing messages as meaningfully as the native client.
In addition, the version is now logged on startup to help troubleshooting.