search

Gk0Wk / TiddlySeq

Logseq-like tiddlywiki5 template plugin.
https://gk0wk.github.io/TiddlySeq
MIT License
35 stars 8 forks source link

Add background-size property to Cover #8

Open Zaphod2012 opened 1 year ago

Zaphod2012 commented 1 year ago

I hope you’re still maintaining/developing this plugin - I have fallen in love with its features (having started using Notion just a few months ago), and use it extensively in my TW.

One thing that I’d like to see implemented, however, is the ability to change the background-size property of the cover. Since there is no ‘move cover’ like in Notion, many of the covers that I’d like to use get cut off or misaligned to omit the very thing I wanted to display in the banner. If we could change the background-size property, this problem would be eliminated by being able to choose a value of ‘contain’ or ‘cover’ (depending on the image dimensions), thereby showing the entire image.

I tried to make the change myself, I looked through the css, but could find no instance of ‘background-size’ so either you are not using it, or it’s being done in some other manner that I didn’t find.

I really think this feature would greatly enhance what is already an outstanding addition to TiddlyWiki, (a plugin which I think not many people have discovered, yet!), making it even better. I hope you will consider adding it.

Thank You

–The Chan Droid

Gk0Wk commented 1 year ago

Hello! Thanks for liking my plugin! The feature you mentioned has been added in v0.0.8. You can choose the background blur, foreground position, size and repeat in the popup menu. They also have corresponding default values, which can be found in Appearance in the Control Panel.

Have fun using it!

Zaphod2012 commented 1 year ago

Thank You so much for the update(s)! :)

But... I can't get it to work in my wiki.

After I upgraded to the 0.0.12 (or 0.0.13) version through the CPL, it does not display any cover, online or local.

I then tried with an empty TW from tiddlywiki.com, and online covers will appear in it, but still not local files.

Then tried deleting the 0.0.11 version and direct installing 0.0.12 (or 0.0.13) fresh, from the github page - same results...

99% of the covers I use in this TW are local files, so I am not too concerned if online links do not work, but it would be nice if they did.

I have tried using relative links (foldername\foldername\image.jpg), full path (drive:\foldername\foldername\image.jpg) and also variations of file:\\\drive:\foldername\foldername\image.jpg (using both forward and backslashes) with no success.

I'm using Windows 11 Home, Version 22H2 with all updates installed. TW version 5.2.7

One bright note: the Icon seems to be functioning just fine :)

EDIT: After upgrading the TW to version 5.3.1, it will now display online covers, but still will not display any local files.

Gk0Wk commented 1 year ago

I've found an issue with the plugin that causes the page-cover field to be misspelled, but local photos seem to be typed correctly. For example the cover for TiddlySeq right now: https://gk0wk.github.io/TiddlySeq/

Zaphod2012 commented 1 year ago

Well, I don't know what the problem was, but I just tried again and it seems to be working correctly, now!

Using forward slashes ( / ) in Windows.

Thank You again for this wonderful plugin! :)