GlPortal / RadixEngine

A free and open game engine.
zlib License
148 stars 58 forks source link

Removing .coveralls.yml to fix #173 #174

Closed chrisosaurus closed 5 years ago

chrisosaurus commented 6 years ago

Hmm this may not work as-is due to the docker container being the way, please see the issue for more up-to-date information as I look into this https://github.com/GlPortal/RadixEngine/issues/173

chrisosaurus commented 6 years ago

Updated which should now run coveralls correctly outside of docker

It is currently undetermined if this will correctly produce coverage information.

chrisosaurus commented 6 years ago

I'm not sure if this is now correctly calculating coverage, it still seems to be at 0% https://coveralls.io/builds/17881231

hhirsch commented 6 years ago

@wow2006 I want to close this without merging. Any objections?

hhirsch commented 6 years ago

Hmm. I think we should cherry pick https://github.com/GlPortal/RadixEngine/pull/174/commits/e9559b3bc81b436fa88fd461f2bdc9a2aafe3667 first.

If that works out we can figure out if and how we remove the coveralls file from the repo.