Glacier-Peak-Studios / mapkitjs

An npm module for Apple's Mapkit.JS. Works nicely with typescript.
MIT License
0 stars 1 forks source link

Fix PolygonOverlay constructor #1

Open Solidsilver opened 4 years ago

Solidsilver commented 4 years ago

Currently the type definition for the PolygonOverlay constructor takes a single array of points. However, according to documentation it can also take a 2-D array of points. To my knowledge this means the constructor should take a 2-D array, and those needing to use a 1-D array need to wrap it. This also may be the case for other overlay constructors.

To Investigate:

To Do:

Note: All overlay constructors can be found in the Overlays type definition file

Solidsilver commented 4 years ago

Note: I did a quick and dirty fix for the PolygonOverlay constructor so my project will work, but this should still be reviewed and fixed in all constructors that need it.