search

GlacierProtocol / glacierprotocol.github.io

the source for https://glacierprotocol.org
28 stars 26 forks source link

Fix text highlights missing #11

Closed another-hodler closed 5 years ago

another-hodler commented 6 years ago

This fixes https://github.com/joaofnfernandes/glacierprotocol.github.io/issues/12

diogomonica commented 6 years ago

Thanks for Thanks for the contributions @another-hodler . Did you generate the PDF to see how it comes out? I'm concerned the won't actually work well.

another-hodler commented 6 years ago

I did generate it but as it is binary I didn't want to commit it - you would need to generate it yourself anyway to check I did not manipulate the content. It looked ok to me since there were just changes in color basically.

diogomonica commented 5 years ago

@another-hodler LGTM but we have some merge conflicts now.

Will try to schedule a point release for next week to include some other fixes merged to master in the meantime.

another-hodler commented 5 years ago

@diogomonica Resolved the conflict. Please note that in some cases I had to use HTML tags and inline styles to make font smaller to fit page width or to wrap content.

It seems like what we need is beyond markdown capabilities and maybe something like https://asciidoctor.org/docs/user-manual/#compared-to-markdown would be a better option.

diogomonica commented 5 years ago

LGTM