GlacioHack / xdem

Analysis of digital elevation models (DEMs)
https://xdem.readthedocs.io/
MIT License
122 stars 37 forks source link

Clarify which angle is needed for DirectionalBias #512

Closed adehecq closed 1 month ago

adehecq commented 2 months ago

The docstring at this line is not clear enough. My understanding is that we need to provide the angle with reference to the x axis, in clockwise direction. That's what I inferred from looking at the results of that line (clever way of not interpolating the data btw 😉), providing the wrong angle means one may look at across-track instead of along-track direction. Ii not clarified, I think it's more intuitive for most people to see it as the angle w.r.t. the y axis, because satellite images are typically only slightly rotated compared to that axis.

rhugonnet commented 1 month ago

Closed by #526