Closed sescandell closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
07b28c6
) 98.21% compared to head (66bd93b
) 98.32%. Report is 4 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
66bd93b(current) vs d6dfdc9 master#2319(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
2 changes
1 improvement
Current Job #2338 |
Baseline Job #2319 |
|
---|---|---|
Initial JS | 5.34MiB (~-0.01% ) |
5.34MiB |
Initial CSS | 303.16KiB |
303.16KiB |
Cache Invalidation | 54.28% |
58% |
Chunks | 51 |
51 |
Assets | 164 |
164 |
Modules | 1454 |
1454 |
Duplicate Modules | 20 |
20 |
Duplicate Code | 0.8% |
0.8% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
1 change
1 improvement
View job #2338 report View sescandell:zwavejs-ui-integratio... branch activity View project dashboard
It seems you're modifying the external_id format
Isn't the current format enough?
It was:
zwavejs-ui:2:0:notification:access_control:door_state_simple
In my case
I've gone back and forth on this so much that I don't really know anymore. Let me check: either I tell you, or I rollback.
@Pierre-Gilles I rolled back the feature external id format. It should be the same as before.
I reverted the serialport update too.
Tests are fine, the CI/CD failed on uploading the report... If you can juste relaunch it.
@sescandell Thanks ! I restarted the tests !
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)~front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Binary Switch support tested with real life device Fibaro Wall plug - FGWPE-102.
Manage displaying state and updating state from the UI. Also working with scenes (when the current implemented door sensor opens, it turns on the Binary Switch)