Closed Terdious closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d87cabc
) 98.21% compared to head (1239faf
) 98.33%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
1239faf(current) vs d87cabc master#2297(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
5 changes
2 regressions
Current Job #2317 |
Baseline Job #2297 |
|
---|---|---|
Initial JS | 5.34MiB (+2.05% ) |
5.23MiB |
Initial CSS | 303.16KiB (+0.2% ) |
302.56KiB |
Cache Invalidation | 58% |
0% |
Chunks | 51 |
51 |
Assets | 167 (+3.73% ) |
161 |
Modules | 1454 (+1.25% ) |
1436 |
Duplicate Modules | 20 |
20 |
Duplicate Code | 0.8% |
0.8% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
4 changes
4 regressions
View job #2317 report View Terdious:netatmo-add-module-indo... branch activity View project dashboard
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add support for NAModule4 type - Weather API / Smart Indoor Module