GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.67k stars 282 forks source link

[WIP] PR n°4 : Add support for NAModule1 type - Weather / Smart Outdoor Module #2012

Closed Terdious closed 9 months ago

Terdious commented 9 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add support for NAModule1 type - Weather API / Smart Outdoor Module

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d87cabc) 98.21% compared to head (cb1dd38) 98.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2012 +/- ## ========================================== + Coverage 98.21% 98.33% +0.12% ========================================== Files 800 839 +39 Lines 12501 13405 +904 ========================================== + Hits 12278 13182 +904 Misses 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 9 months ago

Job #2318: Bundle Size — 9.89MiB (+2.64%).

cb1dd38(current) vs d87cabc master#2297(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 2 regressions
                 Current
Job #2318
     Baseline
Job #2297
Regression  Initial JS 5.34MiB(+2.06%) 5.23MiB
Regression  Initial CSS 303.16KiB(+0.2%) 302.56KiB
Change  Cache Invalidation 58% 0%
No change  Chunks 51 51
Change  Assets 168(+4.35%) 161
Change  Modules 1454(+1.25%) 1436
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 4 changes Regression 4 regressions
|            |       Current
[Job #2318](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2318-Tdu9NsmJFN9aNKqmUpMT?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2297](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2297-ZkW2k1buoYhKjHxhlFYb?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2318-Tdu9NsmJFN9aNKqmUpMT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.03MiB` (`+1.58%`) | `6.92MiB` | | Regression  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2318-Tdu9NsmJFN9aNKqmUpMT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.42MiB` (`+6.31%`) | `2.28MiB` | | Regression  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2318-Tdu9NsmJFN9aNKqmUpMT/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.67KiB` (`+0.19%`) | `319.07KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2318-Tdu9NsmJFN9aNKqmUpMT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Regression  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2318-Tdu9NsmJFN9aNKqmUpMT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.29KiB` (`+4.75%`) | `16.5KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2318-Tdu9NsmJFN9aNKqmUpMT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2318 reportView Terdious:netatmo-add-module-outd... branch activityView project dashboard