GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.57k stars 278 forks source link

Scene: In device.set-value, convert string to number #2013

Closed Pierre-Gilles closed 7 months ago

Pierre-Gilles commented 7 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

Description of change

Fix #2001

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a428cd5) 98.21% compared to head (2b23270) 98.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2013 +/- ## ======================================= Coverage 98.21% 98.21% ======================================= Files 800 800 Lines 12500 12501 +1 ======================================= + Hits 12277 12278 +1 Misses 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-pages[bot] commented 7 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2b23270
Status: ✅  Deploy successful!
Preview URL: https://a6e02b41.gladys-plus.pages.dev
Branch Preview URL: https://fix-string-conversion-issue.gladys-plus.pages.dev

View logs

relativeci[bot] commented 7 months ago

Job #2296: Bundle Size — 9.64MiB (0%).

2b23270(current) vs a428cd5 master#2295(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #2296
     Baseline
Job #2295
No change  Initial JS 5.23MiB 5.23MiB
No change  Initial CSS 302.56KiB 302.56KiB
Change  Cache Invalidation 0% 54.2%
No change  Chunks 51 51
No change  Assets 161 161
No change  Modules 1436 1436
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  no changes
|            |       Current
[Job #2296](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2296-jdheDIqcTA3MEulGfEf1?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2295](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2295-QnFdlsT6tS69zO9qZ0YI?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Not changed  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2296-jdheDIqcTA3MEulGfEf1/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `6.92MiB` | `6.92MiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2296-jdheDIqcTA3MEulGfEf1/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.28MiB` | `2.28MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2296-jdheDIqcTA3MEulGfEf1/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.07KiB` | `319.07KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2296-jdheDIqcTA3MEulGfEf1/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2296-jdheDIqcTA3MEulGfEf1/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `16.5KiB` | `16.5KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2296-jdheDIqcTA3MEulGfEf1/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2296 reportView fix-string-conversion-issue-scen... branch activityView project dashboard